Add a reusable Graphile performance harness - #1813
Merged
Merged
Conversation
|
Review complete. 🟡 1 medium 💬 Inline comments (1)
🧹 Nitpicks (2) — 🟢 2 low
This PR introduces a new performance test harness package under
Reviewed commit: 8f89a88 |
There was a problem hiding this comment.
Adds a new packages/perf-harness package (CLI, worker process, metrics, scheduling, reporting, DB fixtures) plus its tests and CI wiring, with three packaging/cleanup defects to address.
Key findings
- 🟡 Success result overwritten by cleanup failure — stock-worker.ts:75
Zetazzz
force-pushed
the
test/performance-harness-core-single-commit
branch
from
September 7, 2026 09:21
8f89a88 to
27f4dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reusable Graphile performance harness that runs each measurement in a fresh Node process, isolating build timing and memory samples between cases. Suites supply serializable case definitions and a dedicated worker entry for their build and validation logic. This consolidates #1716 and incorporates subsequent review fixes.
cperfexecutable and local workspace script run the command interface.Validation
git diff --check.27f4dc7331e5: 17/17 jobs passed, including 65/65 perf-harness tests.