Repository navigation
health, reflection: depend on connectrpc with default-features = false - #338
Open
AhmedElBanna80 wants to merge 2 commits into
Open
AhmedElBanna80 wants to merge 2 commits into
AhmedElBanna80 wants to merge 2 commits into
Conversation
Fixes connectrpc#337 Signed-off-by: AhmedElBanna80 <[email protected]>
Author
|
Friendly check-in: CI is green on the current head and it still merges cleanly. Happy to adjust the approach, for example if you would rather the two crates re-export the feature flags instead. Thanks for taking a look when you have time. |
|
+1, been using this for over a week, no regressions. |
Author
|
@iainmcgin Gentle ping: main is merged into this branch and it merges cleanly. Could you take a look when you have a moment? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337.
connectrpc-healthandconnectrpc-reflectiondeclared theirconnectrpcdependency withoutdefault-features = false, sogzip/zstd/jsonwere always enabled for their dependents. This setsdefault-features = falseon both, keepingfeatures = ["server"]; theclientfeature still maps toconnectrpc/client.Checked:
cargo test -p connectrpc-health(47 + 4 doc), with--features client(same), and--no-default-features(35 + 4 doc): passcargo test -p connectrpc-reflectionand--features client(21 + 7 doc): passcargo clippy -p connectrpc-health -p connectrpc-reflection --all-targets --all-features -- -D warnings: cleancargo tree -p connectrpc-health --no-default-features -e normal -i zstdlisted connectrpc-health before this change and prints nothing after.cargo test -p connectrpc-reflection --no-default-featuresfails to compile on main already (its tests importServerReflectionClient, which needsclient); unrelated to this change.