Skip to content

health, reflection: depend on connectrpc with default-features = false - #338

Open
AhmedElBanna80 wants to merge 2 commits into
connectrpc:mainfrom
AhmedElBanna80:health-no-default-features
Open

AhmedElBanna80 wants to merge 2 commits into
connectrpc:mainfrom
AhmedElBanna80:health-no-default-features

Conversation

@AhmedElBanna80

Copy link
Copy Markdown

Fixes #337.

connectrpc-health and connectrpc-reflection declared their connectrpc dependency without default-features = false, so gzip/zstd/json were always enabled for their dependents. This sets default-features = false on both, keeping features = ["server"]; the client feature still maps to connectrpc/client.

Checked:

  • cargo test -p connectrpc-health (47 + 4 doc), with --features client (same), and --no-default-features (35 + 4 doc): pass
  • cargo test -p connectrpc-reflection and --features client (21 + 7 doc): pass
  • cargo clippy -p connectrpc-health -p connectrpc-reflection --all-targets --all-features -- -D warnings: clean
  • cargo tree -p connectrpc-health --no-default-features -e normal -i zstd listed connectrpc-health before this change and prints nothing after.

cargo test -p connectrpc-reflection --no-default-features fails to compile on main already (its tests import ServerReflectionClient, which needs client); unrelated to this change.

@AhmedElBanna80

Copy link
Copy Markdown
Author

Friendly check-in: CI is green on the current head and it still merges cleanly. Happy to adjust the approach, for example if you would rather the two crates re-export the feature flags instead. Thanks for taking a look when you have time.

@sachaw

sachaw commented Oct 28, 2026

Copy link
Copy Markdown

+1, been using this for over a week, no regressions.

@AhmedElBanna80

Copy link
Copy Markdown
Author

@iainmcgin Gentle ping: main is merged into this branch and it merges cleanly. Could you take a look when you have a moment?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

connectrpc-health forces connectrpc default features (zstd, gzip, json)

2 participants