boot: in transform_for_boot, also set mtime nanoseconds - #396
Open
alexlarsson wants to merge 1 commit into
Open
alexlarsson wants to merge 1 commit into
alexlarsson wants to merge 1 commit into
Conversation
alexlarsson
force-pushed
the
fix-boot-mtime
branch
from
September 17, 2026 12:06
755d3f5 to
959f303
Compare
Johan-Liebert1
previously approved these changes
Sep 17, 2026
To avoid changes to the /boot and /sysroot mtime due to changes after computing the digest we currently copy the usr mtime to it. However, we're only copying st_mtim_sec, not st_mtim_nsec. This means a change to e.g. /boot on a fs that stores nsec timestamps can still run into this problem. Fix this by copying also the nsec. Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
force-pushed
the
fix-boot-mtime
branch
from
September 17, 2026 12:10
959f303 to
51ef122
Compare
Contributor
Author
|
Fixed some fmt issues |
Contributor
Author
|
Hmm, the rustix issues are not from this repo, and I have no idea why the arch test is failing to start the vm. |
cgwalters
approved these changes
Sep 17, 2026
Contributor
Author
|
Rustix issue seems to be: bytecodealliance/rustix#1620, and waiting on a release |
Contributor
Author
|
Testing a rustix update in #397 |
Collaborator
I wonder now if this hasn't been the source of some composefs digest mismatches various people were hitting... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid changes to the /boot and /sysroot mtime due to changes after computing the digest we currently copy the usr mtime to it. However, we're only copying st_mtim_sec, not st_mtim_nsec.
This means a change to e.g. /boot on a fs that stores nsec timestamps can still run into this problem. Fix this by copying also the nsec.