Repository navigation
Conversation
Author
|
I'm building skyzen (https://github.com/zen-rs/skyzen), an HTTP server framework that runs thread-per-core on compio, with its own HTTP/1.1 and HTTP/3 over io_uring. An early review would let us build on upstream compio rather than a fork. Happy to reshape anything. Also, thank you for building such a great library❤️. |
Berrysoft
reviewed
Nov 11, 2026
| @@ -0,0 +1,65 @@ | |||
| //! The second half of a 32-byte CQE reaches the op through `Extra`. | |||
|
|
|||
| #![cfg(all(io_uring, not(fusion), feature = "io-uring-cqe32"))] | |||
Member
There was a problem hiding this comment.
Also test fusion please. You can use IourOpCode instead.
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
io-uring-cqe32the ring is set up withIORING_SETUP_CQE32, but the driver only passesresandflagson to the op (create_entry, multishot path), so the extra 16 bytes are dropped. Ops that return data there can't be written as anOpCodeon top of compio:IORING_OP_URING_CMD, andIORING_OP_RECV_ZC, whose ring has to be CQE32 in the first place (zcrx.c, v6.18).This copies
big_cqeintoExtraon both paths and addsExtra::big_cqe(), which returnsUnsupportedwhen the feature is off. Without the feature nothing changes size.The test submits a NOP with
IORING_NOP_CQE32, which echoessqe->offandsqe->addrinto the big CQE (nop.c, v6.18), and checks both values come back throughExtra. It passes on Linux 6.18 and skips on older kernels; theio-uring-sqe128,io-uring-cqe32CI lane is the one that builds it.Choosing the CQE size per ring, or
IORING_SETUP_CQE_MIXED, would spare every other ring in the process the larger CQ. I left that out: theio-uringcrate types its CQ by entry size and has no mixed-ring support yet.