Skip to content

feat(net,quic): move UDP GSO/GRO into compio-net - #1050

Open
birneee wants to merge 4 commits into
compio-rs:masterfrom
birneee:feat/udp-gso-gro
Open

feat(net,quic): move UDP GSO/GRO into compio-net#1050
birneee wants to merge 4 commits into
compio-rs:masterfrom
birneee:feat/udp-gso-gro

Conversation

@birneee

@birneee birneee commented Sep 18, 2026 •
edited by Berrysoft
Loading

Copy link
Copy Markdown
Contributor

Closes #1049

George-Miao
George-Miao requested changes Sep 18, 2026
View reviewed changes

@George-Miao George-Miao left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd normally have a sys mod for something like this. Also please have some description either in the PR or in the referenced issue. PR name need to be fixed. Make sure you read our contribution guide line before making PR's.

@birneee birneee changed the title Move UDP GSO/GRO into compio-net feat(net,quic): move UDP GSO/GRO into compio-net Sep 18, 2026
@github-actions github-actions Bot added enhancement New feature or request package: net Related to compio-net package: quic Related to compio-quic labels Sep 18, 2026
@birneee

birneee commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

i created a sys mod; added a issue description; and fixed PR name;

Berrysoft
Berrysoft requested changes Sep 24, 2026
View reviewed changes
Comment thread compio-net/src/lib.rs Resolved
Comment thread compio-net/src/udp.rs Resolved
George-Miao
George-Miao requested changes Sep 24, 2026
View reviewed changes
Comment thread compio-net/src/offload/mod.rs Resolved
Comment thread compio-net/src/offload/windows.rs Resolved
Comment thread compio-net/src/offload/mod.rs Resolved
Comment thread compio-net/src/offload/linux.rs Resolved
@birneee
fix(quic): cap GSO batches to the max UDP payload
13d542e
@birneee
refactor(net): address offload review feedback
4832d08 
- private offload module, re-export push_gso_segment_size/gro_segment_size
- mod + `use ... as imp` and cfg_select in the platform modules
- no panic on empty control buffer in gro_segment_size
- 64 GSO segments on Linux (udp(7))
- document why Windows GRO is opt-in (quinn-rs/quinn#2041)
- GSO/GRO roundtrip test
@birneee
fix(net,quic): fix clippy and fmt on CI
7140207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Berrysoft Berrysoft Berrysoft approved these changes
@AsakuraMizu AsakuraMizu Awaiting requested review from AsakuraMizu
@George-Miao George-Miao Awaiting requested review from George-Miao

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request package: net Related to compio-net package: quic Related to compio-quic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move UDP offloading (GSO/GRO) into compio-net

3 participants

@birneee @Berrysoft @George-Miao