feat: Better Players - #1053
Draft
nnra6864 wants to merge 1 commit into
Draft
feat: Better Players#1053nnra6864 wants to merge 1 commit into
nnra6864 wants to merge 1 commit into
Conversation
fix: Saving the preMuteVolume instead of regular volume to prefs style: Adjusted naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement basic controls to media players, such as volume changing.
I'll also look into implementing
.mkvand.jxlsupport.I could also try implementing #1052 if it's not merged by the time I get to it.
For now, I implemented the persistent audio player volume control, and will start working on the video player.
If you'd like, I can split the format support into a separate PR, whatever works the best for you.
closes #1051