feat: move pebble to v2 - #290
Draft
mmsqe wants to merge 1 commit into
Draft
Conversation
|
PR author is not in the allowed authors list. |
mmsqe
marked this pull request as draft
August 28, 2026 02:07
v2 fails a compaction on a block it cannot read instead of passing over it, and routes every detection through EventListener.DataCorruption. A node that arrives here without having been through the ratchet release is refused, and told to go back and take it -- the one move it cannot make is forward, since v2 rejects the format before it would migrate it. These stores open first, so this is where such a node stops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2 has the fix that fails a compaction on a block it cannot read rather than passing over it.
Existing databases sit at format major version 1, which v2 refuses to open, so the ratchet has to ship and roll out before this does.
PR checklist
.changelog(we use unclog to manage our changelog)