Skip to content

perf(goleveldb): use LevelDB Has to skip value reads - #288

Open
songgaoye wants to merge 2 commits into
cometbft:mainfrom
songgaoye:song/perf_goleveldb_Has
Open

perf(goleveldb): use LevelDB Has to skip value reads#288
songgaoye wants to merge 2 commits into
cometbft:mainfrom
songgaoye:song/perf_goleveldb_Has

Conversation

@songgaoye

Copy link
Copy Markdown

Replace Get() call with native LevelDB Has() method to check key existence without reading the value data.
This reduces I/O and memory overhead for Has() operations.

the same cosmos/cosmos-db#145


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)

@songgaoye
songgaoye requested a review from a team as a code owner August 27, 2026 10:06
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

PR author is not in the allowed authors list.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.37%. Comparing base (fb4f703) to head (a682ce8).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   76.80%   79.37%   +2.56%     
==========================================
  Files          23       23              
  Lines        2048     1697     -351     
==========================================
- Hits         1573     1347     -226     
+ Misses        403      280     -123     
+ Partials       72       70       -2     
Files with missing lines Coverage Δ
goleveldb.go 63.46% <100.00%> (+3.61%) ⬆️

... and 21 files with indirect coverage changes

Files with missing lines Coverage Δ
goleveldb.go 63.46% <100.00%> (+3.61%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant