Repository navigation
Data toolkit/collectionspace_migration_tools (CMT) support - #23
Merged
Merged
Conversation
Assuming the CSV Importer Docker container contains a copy of this code that uses a compatible Ruby version, we can upgrade this to use the version being used by the Data Toolkit
The standard inflection of filename "refcache" is Refcache. The filename that would inflect to RefCache is ref_cache. Nonstandard inflection is a pain in modern Ruby/Rails where autoloaders like Zeitwerk are common/standard.
kspurgin
requested review from
mark-cooper
and removed request for
mark-cooper
October 27, 2026 20:01
Contributor
Author
|
@mark-cooper - collectionspace_migration_tools (CMT) has been pointed at the Today I just bumped up the Ruby version and made other changes to get stuff to pass |
mark-cooper
approved these changes
Oct 28, 2026
Contributor
Author
|
@mark-cooper - Are you ok with me merging this when I have time to also update the collectionspace-mapper and collectionspace_migration_tools (CMT) which currently point to the branch being merged here? |
Contributor
Author
|
(That will be soon, as I'm trying to get this branch heck cleaned up before Will is back next week) |
Member
|
@kspurgin yes, absolutely. Just let me know if there's anything I specifically need to do 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that Data Toolkit and CMT have different caching approaches, both of which are supported by collectionspace-mapper via this Gem, we do still need this as a consistent syntax layer for caching.
Assuming the version of this Gem compatible with CSV Importer is living in its Docker container, we should be able to update this, so that collectionspace-mapper can point to
masterinstead of a branch.(I guess we should also rename the default branch to
main, but one thing at a time`)This PR:
RefCachetoRefcachefor Zeitwerk-app compatibility (without having to create custom inflectors in each using app)