feat(ruby): isStatic, attr_accessor synthesis, brace-block calls Prism dispatcher fan-out#1404
Open
sadfuzzy wants to merge 1 commit into
Open
feat(ruby): isStatic, attr_accessor synthesis, brace-block calls Prism dispatcher fan-out#1404sadfuzzy wants to merge 1 commit into
sadfuzzy wants to merge 1 commit into
Conversation
…Prism dispatcher fan-out — closes hover/listener flow end-to-end, validated on ruby-lsp
sadfuzzy
marked this pull request as draft
July 22, 2026 07:15
sadfuzzy
marked this pull request as ready for review
July 22, 2026 13:20
Author
Author
|
@colbymchenry please, review this fix for ruby language support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeGraph's Ruby support had real gaps an agent hits constantly:
def self.x/class << selfmethods indistinguishable from instance methods,attr_accessor/attr_reader/attr_writerinvisible (calls to them resolvedto nothing), brace-block bodies (
5.times { beep }) blind to bare-call extraction whiledo...endwasn't, and Prism-dispatcher visitor architectures (ruby-lsp's core pattern:dispatcher.register(self, :on_x)→dispatcher.dispatch(...)) had zero dynamic-dispatch bridging — an agent tracing "hover request → handler" had no static path and had to grep every listener file.Root cause
Fix
class << selfparent-chain check).Request-wrapper indirection, and handles instance-variable-threaded dispatchers (@dispatcher set in initialize, read in a sibling perform) — while keeping sibling methods with same-named unrelated local
dispatcher vars from cross-linking.
Validated
labeled and sited.