Repository navigation
Conversation
This was referenced Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Callback insertion could change the pointer list or ownership registry before all throwing allocations completed, leaving partial state when a C++ allocation threw.
Changes
The guarantee covers throwing C++ allocations exercised by the oracle. It does not turn underlying allocator exhaustion into a recoverable exception or replace Coin's OOM policy. Callback/userdata pointers retain their existing borrowing semantics; class layout and public signatures are unchanged.
Base
Independent contribution over upstream master; no unpublished prerequisite is required.
Upstream master:
ca247c1321bce07199ec0f034493977761b3218e.Validation
Linux candidate 86/86 CTests at
ffba47d0b5ff664790ab6277b39dc71c6f07ab65, with no skips. Dedicated integration lab previously passed 140/140 atf26ae1800f9de3a224ba63b34ddad3f704db9d60; that lab count is a separate reviewed snapshot.Fresh publication gate of all eight exact heads: 35/35 directed and 153/153 total CTests, no skips, at
e6687c088077082e6839b4fc39c632d5267b07d8. GCC/Ninja Debug shared build with COIN_THREADSAFE=ON and external Expat, build and compiler temporary files in RAM; Xvfb/software GLX environment.git diff --checkpassed for the proposed delta. Native Windows/macOS and formal ABI checks rerun on this published head.