Repository navigation
Conversation
# Conflicts: # src/misc/SbHash.h
30 of 37 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The third and subsequent rbptree insertions allocate nodes. A failed allocation was dereferenced before the API could report anything; insert() has no failure return.
Changes
Tree representation, public signatures and borrowed pointer/data ownership are unchanged. This contribution is the rbptree node check and its regression; the allocator and dictionary changes belong to #772.
Dependencies — keep as draft
Depends on #772. The diff against master includes the prerequisite stack. The contribution over the reviewed base is linked below; narrow/rebase the PR after its prerequisites are integrated.
Base:
c434d067dc8686893ee3dcb9e38123766e365904(codex/cc-oom-consumers). Review this contribution over its base.Validation
Linux candidate 98/98 CTests at
3b5e04b1e98164157405623e43d0d6da61343644, with no skips. Dedicated integration lab previously passed 140/140 atbae0edd15cd859aee8165d20a37026661854bfba; that lab count is a separate reviewed snapshot.Fresh publication gate of all eight exact heads: 35/35 directed and 153/153 total CTests, no skips, at
e6687c088077082e6839b4fc39c632d5267b07d8. GCC/Ninja Debug shared build with COIN_THREADSAFE=ON and external Expat, build and compiler temporary files in RAM; Xvfb/software GLX environment.git diff --checkpassed for the proposed delta. Native Windows/macOS and formal ABI checks rerun on this published head.