Repository navigation
Conversation
# Conflicts: # src/misc/SbHash.h
This was referenced Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Repeated registrations of the same auditor pointer can dispatch multiple notifications for a single SoBase notification. Deduplication state must be local to each notification so nested notifications and exception propagation do not poison subsequent calls.
Changes
Deduplication is by pointer. A removed auditor is skipped; an auditor added during traversal is deferred to the next notification. SoNotList copying remains shallow. Auditor pointers remain borrowed. Identical pointer/data pairs removed and reinserted do not acquire a stable occurrence identity.
Dependencies — keep as draft
Requires traversal PR #826 at
43bf8ebee153284c45a4e7699bf3ed4135460c28. That prerequisite depends on #772 and the pointer-order change of #813. Its traversal contract was reviewed separately, including allocated snapshots, mutation, reentry and callback exceptions.Traversal prerequisite PR.
Review the deduplication delta over its prerequisite.
The master diff remains cumulative. Keep this PR as draft until its prerequisite contributions are integrated and the diff can be narrowed to deduplication.
Validation
Linux candidate 94/94 CTests and individual integration lab 133/133. A diagnostic version with deduplication disabled failed the duplicate-notification regression. Focused nested, throwing and mutating notification cases passed with ASan/UBSan/vptr and LeakSanitizer in the combined review. The final publication integration gate is recorded below.
Final publication gate — 2026-10-08
The exact published heads, merged over the existing integration lab, passed 13/13 directed CTests and 139/139 total CTests, with no skips. GCC/Ninja Debug shared build, COIN_THREADSAFE=ON, external Expat, all build/compiler temporary files in RAM. The GLX test environment used Xvfb, LIBGL_ALWAYS_SOFTWARE=1 and COIN_GLX_PIXMAP_DIRECT_RENDERING=1. The initial full run omitted the latter setting and failed to create GLX contexts; the corrected environment passed without code changes. Integration commit: bc83f34.
Native Windows/macOS and ABI checks are left to this PR's CI.
Current publication gate — 2026-10-09
Current head
3d313b82595111cfec0942ee47a5383467993eaaincorporates the MSVC-only exception-fixture option from traversal PR #826. This changes only CcRbptreeTraverseTest compilation; the deduplication production delta is unchanged. The earlier Windows run failed that fixture with 0xc0000409; the corrected native run is pending.The earlier deduplication candidate passed 102/102 CTests at
4c748ae4c1424a763924909c2d54a9d0fc1aafa6, and its dedicated lab passed 134/134. The fresh publication composition of all eight new PR heads and this exact head passed 35/35 directed and 153/153 full CTests, no skips, ate6687c088077082e6839b4fc39c632d5267b07d8. GCC/Ninja Debug shared build, thread safety enabled, external Expat, RAM build/TMPDIR, Xvfb/software GLX. Current native Windows/macOS and ABI checks rerun on this head.