Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first SoBase::getAuditors() call can keep its local list pointer null after inserting the cache entry. Refreshing a cached list with a forward removal loop also leaves stale entries after index shifts. The cached list must additionally be deleted when its owning SoBase is destroyed.
Changes
The returned list remains borrowed; its lifetime ends with the SoBase. Existing public signatures and object layout are unchanged.
Validation
Linux Debug shared/threadsafe build: candidate 88/88 CTests and previous integration lab 132/132. Three focused tests passed with ASan/UBSan/vptr and LeakSanitizer; the lifetime reproducer previously reported 1,008 bytes in 18 allocations. The final publication integration gate is recorded below.
Independent of the other SoBase candidates. Upstream integration remains the maintainers' decision.
Final publication gate — 2026-10-08
The exact published heads, merged over the existing integration lab, passed 13/13 directed CTests and 139/139 total CTests, with no skips. GCC/Ninja Debug shared build, COIN_THREADSAFE=ON, external Expat, all build/compiler temporary files in RAM. The GLX test environment used Xvfb, LIBGL_ALWAYS_SOFTWARE=1 and COIN_GLX_PIXMAP_DIRECT_RENDERING=1. The initial full run omitted the latter setting and failed to create GLX contexts; the corrected environment passed without code changes. Integration commit: bc83f34.
Native Windows/macOS and ABI checks are left to this PR's CI.