Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get()usesSbPList::operator[], which can expand a const array during a read. Unsigned indices outside the backend's signed domain also reach unchecked list operations. Removing a missing item can forward an invalid index.Change
Check indices before converting to the backend's
intdomain. Use a non-growing lookup; invalid reads return NULL. Invalid mutations and removal of a missing item are no-ops, insertion accepts the end position, and truncation only shrinks. Document the contract in the internal header. On Windows shared builds, compile the private dynarray implementation directly intoCoinTests, following the existing dictionary support pattern; its symbols are not exported from the DLL.Validation
Integration and platform coverage
All nine reviewed candidates were tested together in a separate integration worktree: 129/129 CTests, 9 embedded tests/92 checks, and the dedicated regression executables. Candidate builds used Ninja/Debug, a shared library, tests and thread safety enabled, with the full suite under Xvfb/GLX and software rendering. Builds were kept in RAM.
Native Windows was not run locally; platform CI remains part of the PR validation.
Publication base:
ca247c1321bce07199ec0f034493977761b3218e.