Repository navigation
Move chats in the background with a live progress card - #235
Merged
Merged
Conversation
The move dialog closes right away and a card in the corner shows each step, the bytes of the session copy with percent, speed and time left, so a slow connection no longer freezes the dialog. The runner reports the handover size up front, and the handover and push timeouts allow 15 minutes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a slow connection moving a chat to another Mac froze the dialog with a spinner for a long time.
What changes
chat.moveevent (packages/core/src/remote/chatMoves.ts), sent at most 4 times a second. Windows opened during a move get it in the welcome events.GET /api/link/conversations/:id/handover/size), and the controller reads the bytes received so far from the link channel. Older runners without the size route show the MB copied and an indeterminate bar.Tests
pnpm -r typecheckpassespackages/core/test/chat-moves.test.ts(steps, bytes, throttling, failed moves)cloud-scope,devices-e2e,remote-handover,remote-linktests pass (53/53)