Repository navigation
Make file and folder paths clickable in chats on another computer - #230
Merged
Merged
Conversation
A chat on a runner or another device of the group asked only that computer which of the named paths exist. While it was offline the request failed and no path became a link, and files the agent wrote on this computer were never found. Paths are now looked up on the runner first, then here, and a file found here opens in Finder while one on the runner copies its path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a chat that belongs to another computer (a runner or a device of the group, e.g. "MacBook Pro von m"), paths like
workspace/racechip-return/stayed plain text. The app asked only that computer which of the named paths exist. While it was offline the request failed withrunner_offline, so no path became a link. Files the agent had written on this computer were never found either.Fix
POST /api/conversations/:id/filesfor a runner chat now asks the runner first (30 s timeout), then looks the paths up on this computer. A runner that is offline or doesn't answer falls back to this computer.ChatFile.remotemarks files that were found on the runner. In the app, a file found on this computer opens in Finder, and one found on the runner copies its path. Previously every path in a runner chat only copied its path. Pictures are fetched from the runner only when they are on the runner.Tests
remote: true); offline, the paths are still found here.pnpm typecheckpasses.