Repository navigation
Device groups: phones learn about a computer that switched phone access on later - #221
Merged
Merged
Conversation
…ss on later A computer's info (where phones reach it) was only read at connect. A secondary that got phone access after it connected (when a phone pairing arrived) never showed up in the primary's group list, so a phone paired with the primary had nowhere to fail over to. Each pull now asks again, the group is announced when a phone address changed, the computer that switched phone access on says so at once, and the phone app reloads its group list on devices.updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking #218 with the real phone app in the simulator: a phone paired with the primary got a group list with only the primary. The secondary switched its phone access on when the pairing arrived, but the primary only read the secondary's info (its phone address) at connect, so the phone had nowhere to fail over to.
refreshRunnerInfo); when its phone address changed, the group is announced (devices.updated)./api/mobile/me) ondevices.updated.devices-e2e.test.ts).Tests: devices-e2e, replica, mobile pass; core and phone typecheck pass.