Repository navigation
Document the dispersion parity scenes in cycles-parity.md (#1714) - #2003
Merged
Merged
Conversation
Names the three scenes the Cook repo keeps for #1714, the measured numbers, and the commands that run both renderers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1714
What changed
docs/cycles-parity.mdgets a "Dispersion (Materials: spectral dispersion for glass and gems (Cook), and read KHR_materials_dispersion #1714)" section: the three parity scenes (prism-view,gem,prism-floor) that codepawl/cook keeps intools/dispersion-scenes.mjs, which scenes are measured, the measured Cook and Cycles numbers, and the commands that run both renderers.dispersionmaterial field traced spectrally (Trace spectral dispersion for glass: hero wavelength per path (#46) cook#49, Pass glass dispersion to Cook and read KHR_materials_dispersion (#1714) #1764, Pin Cook with signed dispersion weights and clamp negative pixels before denoising (#1714) #1780, signed weights in Keep the sign of the spectral weight so dispersion fringes match Cycles (#50) cook#53) andKHR_materials_dispersionread on import (Pass glass dispersion to Cook and read KHR_materials_dispersion (#1714) #1764,tests/gltf-extensions.test.js).prism-flooris listed as not resolved: a rainbow on a diffuse floor is a caustic, tracked in Cook: refractive caustics from small emitters stay speckle at 512 spp (no MNEE or caustic pass) #1715.How I checked it
npm run preflight -- --skip-tests: exit 0 (links, fast tests ok; the rest skipped because only a doc changed).tools/dispersion-parity.mjs,tools/dispersion-parity-cycles.py,tools/dispersion-parity-compare.py). I did not run Blender for this PR; the numbers come from the measurements in Pass glass dispersion to Cook and read KHR_materials_dispersion (#1714) #1764 anddocs/path-tracer.md.Evidence
Docs only, nothing to show. The pictures for the numbers are in #1764.