fix update restart guidance and daemon shutdown wait - #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows updates already install the replacement on the first run, but the running updater or daemon can keep the parked old executable locked. The previous success output looked like a failure, leading users to run update twice.
Successful updates now state that no second update is needed and give the exact session restart command.
nightcrow stopalso waits for the daemon socket to be released within its existing shutdown deadline, removing the stop-then-update race.Validation:
unix-gate: 1,929 tests passed / 5 ignored; recovery plugin 154 passed