fix terminal subprocess cleanup and clarify repo input focus - #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pane and project close previously terminated only the directly spawned PTY child, so descendant processes could survive. Closing a pane from either TUI or Web now terminates its Unix session or Windows Job Object, while project close applies the same cleanup to every pane; close requests also use a lossless control path outside the bounded input queue.
Opening the repo dialog with
Ctrl+F, thenCtrl+O, now gives the bottom input row stable side rails that pulse in the accent color twice to make the focus move visible.Validation:
cargo fmt --all --checkcargo buildcargo test(Windows: 1,857 passed, 5 ignored)cargo clippy --all-targets --all-features -- -D warningsdocker compose run --rm unix-gate(Linux: 1,925 passed, 5 ignored; recovery plugin: 155 passed)