fix(release): skip native scripts during npm setup - #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The npm release workflow ran dependency lifecycle scripts even though release validation only needs TypeScript and test dependencies. On the current Linux runner, Canvas had no compatible prebuild and its source fallback failed because
pangocairodevelopment headers are not installed.Failed run: https://github.com/code-yeongyu/senpi/actions/runs/31675074971
Fix
--ignore-scripts..github/changes.md.Native artifacts remain explicitly rebuilt in the separate binary release workflow.
Verification
npm run check— passed.actionlint .github/workflows/publish-npm.yml— passed.v2026.8.13tag or npm version exists.Summary by cubic
Skip native lifecycle scripts during dependency install in the npm release workflow to keep release validation independent of native toolchains. Previously
npm installran package scripts (e.g.,canvasbuild) and failed on missingpangocairo; now we install with--ignore-scriptsso TypeScript and test dependencies install cleanly..github/workflows/publish-npm.yml, the install step usesnpm install --ignore-scripts --no-audit --no-fund.scripts/publish-workflow.test.mjsasserts the exact no-script install command..github/changes.md.Written for commit 521b219. Summary will update on new commits.