Skip to content

feat(tips): auto-enable tipping when resolving a scanned or deeplinked tip card#1154

Merged
bmc08gt merged 1 commit into
code/cashfrom
feat/auto-enable-tipping-on-resolve
Jul 26, 2026
Merged

feat(tips): auto-enable tipping when resolving a scanned or deeplinked tip card#1154
bmc08gt merged 1 commit into
code/cashfrom
feat/auto-enable-tipping-on-resolve

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

What

When a user encounters someone else's tip card — either by scanning it or opening a tip deeplink — we now auto-enable the Tipping beta flag for them so they can reciprocate without first digging the flag out of beta settings.

Both entry points funnel through a single method, so the flag flip lives in one place:

  • Scan → CodeScanDelegate.Event.TipCardScannedresolveTipCard(userId)
  • Deeplink → DeeplinkAction.PresentTipCardresolveTipCard(userId)

How

  • Injected FeatureFlagController into TippingCoordinator and call set(FeatureFlag.Tipping, true) in resolveTipCard(userId)'s onSuccess block (only after the counterparty's profile resolves successfully; before the tip card itself is assembled).
  • FeatureFlag.Tipping is what drives isTippingEnabled in RealSessionController, so this opts the viewer into the full tipping experience.
  • Added the :apps:flipcash:shared:featureflags module dependency to shared:tipping.

The flip is a no-op when the flag is already on, and does not fire when profile resolution fails.

Tests

Added coverage to TippingCoordinatorTest:

  • flag enabled on successful resolve
  • flag untouched when resolution fails

Also wired the vibrator constructor arg the existing test was missing after the earlier vibrate change. All 6 tests in the module pass.

@github-actions github-actions Bot added the type: feature New functionality label Jul 26, 2026
@bmc08gt
bmc08gt merged commit 0c773f6 into code/cash Jul 26, 2026
3 checks passed
@bmc08gt
bmc08gt deleted the feat/auto-enable-tipping-on-resolve branch July 26, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant