feat(tips): auto-enable tipping when resolving a scanned or deeplinked tip card#1154
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a user encounters someone else's tip card — either by scanning it or opening a tip deeplink — we now auto-enable the
Tippingbeta flag for them so they can reciprocate without first digging the flag out of beta settings.Both entry points funnel through a single method, so the flag flip lives in one place:
CodeScanDelegate.Event.TipCardScanned→resolveTipCard(userId)DeeplinkAction.PresentTipCard→resolveTipCard(userId)How
FeatureFlagControllerintoTippingCoordinatorand callset(FeatureFlag.Tipping, true)inresolveTipCard(userId)'sonSuccessblock (only after the counterparty's profile resolves successfully; before the tip card itself is assembled).FeatureFlag.Tippingis what drivesisTippingEnabledinRealSessionController, so this opts the viewer into the full tipping experience.:apps:flipcash:shared:featureflagsmodule dependency toshared:tipping.The flip is a no-op when the flag is already on, and does not fire when profile resolution fails.
Tests
Added coverage to
TippingCoordinatorTest:Also wired the
vibratorconstructor arg the existing test was missing after the earlier vibrate change. All 6 tests in the module pass.