Skip to content

fix(resolver): drop in-memory resolution cache #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jul 24, 2026
Merged

fix(resolver): drop in-memory resolution cache #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions services/flipcash/src/main/kotlin/com/flipcash/services/controllers/ResolverController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import com.flipcash.services.repository.ResolverRepository
import com.flipcash.services.user.UserManager
import com.getcode.opencode.model.core.ID
import com.getcode.solana.keys.PublicKey
import java.util.concurrent.ConcurrentHashMap
import javax.inject.Inject
import javax.inject.Singleton

Expand All @@ -15,13 +14,6 @@ class ResolverController @Inject constructor(
private val repository: ResolverRepository,
private val userManager: UserManager,
) {
// Memoizes successful resolutions for the process lifetime. An identity's on-chain address is
// effectively immutable, and callers commonly resolve the same identity twice in quick
// succession (e.g. a chat pre-resolves the recipient to gate the send button, then the payment
// delegate resolves it again at send time) — the cache turns the second into a no-op. Failures
// are never cached, so an unresolvable identity is retried.
private val cache = ConcurrentHashMap<ResolveIdentifier, PublicKey>()

/** Resolves a phone number to its on-chain address. */
suspend fun resolve(phone: ContactMethod.Phone): Result<PublicKey> =
resolve(ResolveIdentifier.Phone(phone))
Expand All @@ -31,10 +23,8 @@ class ResolverController @Inject constructor(
resolve(ResolveIdentifier.UserId(userId))

private suspend fun resolve(identifier: ResolveIdentifier): Result<PublicKey> {
cache[identifier]?.let { return Result.success(it) }
val owner = userManager.accountCluster?.authority?.keyPair
?: return Result.failure(Throwable("No account cluster in UserManager"))
return repository.resolve(owner, identifier)
.onSuccess { cache[identifier] = it }
}
}
Loading