feat(tipping): distinct tip-card color inside the tip sheet#1145
Merged
Conversation
Introduce `LocalTipCardColor` so the tip card's background can be overridden
per surface. `TipCard` reads it and falls back to the theme color when no
value is provided (`takeOrElse { CodeTheme.colors.tipCardColor }`), so
existing standalone renders are unaffected.
The tip sheet (`TipCardScreen`) provides the darker `0xFF101011`, while the
default theme `tipCard` color moves to `0xFF2A2620` for standalone rendering.
github-actions
Bot
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Render the tip card in a surface-specific background color: a darker tone inside the tip sheet, and a new default tone everywhere else.
Changes
LocalTipCardColor(TipCard.kt) — astaticCompositionLocalOffor the card background.TipCardreads it with a theme fallback:LocalTipCardColor.current.takeOrElse { CodeTheme.colors.tipCardColor }, so any render without a provider keeps the theme color.TipCardScreenprovidesColor(0xFF101011)around the card, so the tip sheet keeps the darker near-black.FlipcashDesignSystem) — defaulttipCardcolor moves0xFF101011→0xFF2A2620for standalone renders.ScannableRenderer— braces around theTipCardbranch (cosmetic).Testing
:apps:flipcash:shared:bills,:shared:theme,:features:tippingcompile.