Skip to content

fix: Stop sbt publishing the CLI Docker image - #566

Merged
lolgab merged 1 commit into
masterfrom
fix/skip-sbt-docker-publish
Oct 22, 2026
Merged

lolgab merged 1 commit into
masterfrom
fix/skip-sbt-docker-publish

Conversation

@pedrobpereira

Copy link
Copy Markdown
Contributor

Changes

The CLI project no longer builds a Docker image through sbt publish/publishLocal. The image is now only built from the Dockerfile in CI.

Manual Testing

  • sbt codacyAnalysisCli/publishLocal succeeds without a Docker build, and the core and toolRepositoryRemote jars still publish
  • Not tested: a real sbt +publish to S3

@codacy-production

codacy-production Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-0.50%)
Diff coverage ✅ ∅ diff coverage (50.00%)

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (dd61b2e) 1285 1048 81.56%
Head commit (7a9afd0) 1285 (+0) 1048 (+0) 81.56% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#566) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

✅ No blocking issues noticed

No blocking code findings were identified. The acceptance criteria remain unverified because no automated tests or coverage data were provided, including the real sbt publishing path.

About this PR

  • Please add or run automated checks covering the sbt publish/publishLocal behavior, preservation of core and toolRepositoryRemote JAR publishing, and the CI Dockerfile build path.

Test suggestions

  • Run codacyAnalysisCli/publishLocal and verify no Docker build occurs.
  • Run sbt publish and verify no CLI Docker image is built or published.
  • Verify core and toolRepositoryRemote JARs still publish.
  • Verify the CI Dockerfile build remains the Docker image build path.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Run codacyAnalysisCli/publishLocal and verify no Docker build occurs.
2. Run sbt publish and verify no CLI Docker image is built or published.
3. Verify core and toolRepositoryRemote JARs still publish.
4. Verify the CI Dockerfile build remains the Docker image build path.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@pedrobpereira
pedrobpereira marked this pull request as ready for review October 22, 2026 13:58
sbt's default image uses the removed openjdk:8 base, failing publish_lib; the real image comes from the Dockerfile.
@pedrobpereira
pedrobpereira force-pushed the fix/skip-sbt-docker-publish branch from 5131cc0 to 7a9afd0 Compare October 22, 2026 14:14

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

✅ No blocking issues noticed

No new blocking findings were identified. The acceptance criteria remain unverified by automated tests, including preservation of JAR publishing and the CI Dockerfile workflow.

Test suggestions

  • Verify codacyAnalysisCli/publishLocal completes without invoking a Docker build.
  • Verify core and toolRepositoryRemote JARs still publish after the CLI publish configuration changes.
  • Verify a real sbt +publish does not attempt to publish the CLI Docker image.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify codacyAnalysisCli/publishLocal completes without invoking a Docker build.
2. Verify core and toolRepositoryRemote JARs still publish after the CLI publish configuration changes.
3. Verify a real sbt +publish does not attempt to publish the CLI Docker image.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

@lolgab
lolgab merged commit bd57cda into master Oct 22, 2026
8 checks passed
@lolgab
lolgab deleted the fix/skip-sbt-docker-publish branch October 22, 2026 15:37
@lolgab
lolgab restored the fix/skip-sbt-docker-publish branch October 22, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants