Repository navigation
fix: Stop sbt publishing the CLI Docker image - #566
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.00% coverage variation (-0.50%) |
| Diff coverage | ✅ ∅ diff coverage (50.00%) |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (dd61b2e) 1285 1048 81.56% Head commit (7a9afd0) 1285 (+0) 1048 (+0) 81.56% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#566) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking code findings were identified. The acceptance criteria remain unverified because no automated tests or coverage data were provided, including the real sbt publishing path.
About this PR
- Please add or run automated checks covering the sbt publish/publishLocal behavior, preservation of core and toolRepositoryRemote JAR publishing, and the CI Dockerfile build path.
Test suggestions
- Run codacyAnalysisCli/publishLocal and verify no Docker build occurs.
- Run sbt publish and verify no CLI Docker image is built or published.
- Verify core and toolRepositoryRemote JARs still publish.
- Verify the CI Dockerfile build remains the Docker image build path.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Run codacyAnalysisCli/publishLocal and verify no Docker build occurs.
2. Run sbt publish and verify no CLI Docker image is built or published.
3. Verify core and toolRepositoryRemote JARs still publish.
4. Verify the CI Dockerfile build remains the Docker image build path.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
sbt's default image uses the removed openjdk:8 base, failing publish_lib; the real image comes from the Dockerfile.
5131cc0 to
7a9afd0
Compare
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No new blocking findings were identified. The acceptance criteria remain unverified by automated tests, including preservation of JAR publishing and the CI Dockerfile workflow.
Test suggestions
- Verify codacyAnalysisCli/publishLocal completes without invoking a Docker build.
- Verify core and toolRepositoryRemote JARs still publish after the CLI publish configuration changes.
- Verify a real sbt +publish does not attempt to publish the CLI Docker image.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify codacyAnalysisCli/publishLocal completes without invoking a Docker build.
2. Verify core and toolRepositoryRemote JARs still publish after the CLI publish configuration changes.
3. Verify a real sbt +publish does not attempt to publish the CLI Docker image.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Changes
The CLI project no longer builds a Docker image through
sbt publish/publishLocal. The image is now only built from the Dockerfile in CI.Manual Testing
sbt codacyAnalysisCli/publishLocalsucceeds without a Docker build, and the core and toolRepositoryRemote jars still publishsbt +publishto S3