Repository navigation
Floor serialized variances at compute boundaries - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
One-pass
float32variance estimates can serialize as zero or slightly negative. Direct serialized-array readers bypass the positive variance invariant established bygauden_tmodel loading, so KD-tree geometry, density splitting, MAP priors, and MMIE updates can produce non-finite results.Fix
Add shared diagonal and full-covariance array floor helpers and apply them after affected computational reads.
map_adapthonors-varfloor; other consumers use the existing1e-4evaluation floor. Raw serialized artifacts and copy/passthrough paths remain lossless. Add a CTest regression.libclust/kdtree.cremains unchanged because its caller now establishes the invariant beforelog()andsqrt()computations.Reader audit
Routed:
inc_comp,kdtree,map_adapt, and MMIEnorm.Already protected locally:
libmodinv/mod_inv.c,mllr_solve,bldtree, andmake_quests.Display/copy/initialization/template reads left lossless:
printp,cp_parm,init_mixw, and the othernormrereads. The remainingmllr_transformandinit_gausites read means.Verification
cmake -S . -B buildcmake --build buildctest --test-dir build --output-on-failure(1/1 passed)This ports the landed boundary and consumer routing from pstrain PR #134.