fix: Increase pointer target of expandable section navigation trigger - #4876
Open
Harsh-Anand-Singh wants to merge 5 commits into
Open
fix: Increase pointer target of expandable section navigation trigger#4876Harsh-Anand-Singh wants to merge 5 commits into
Harsh-Anand-Singh wants to merge 5 commits into
Conversation
Harsh-Anand-Singh
requested review from
SpyZzey and
avinashbot
and removed request for
a team and
SpyZzey
August 6, 2026 13:57
Harsh-Anand-Singh
enabled auto-merge
August 6, 2026 13:59
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4876 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 958 958
Lines 31238 31242 +4
Branches 11530 11531 +1
=======================================
+ Hits 30501 30505 +4
Misses 690 690
Partials 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SpyZzey
requested changes
Aug 6, 2026
…tion-pointer-target # Conflicts: # src/expandable-section/expandable-section-header.tsx
…tion-pointer-target
SpyZzey
requested changes
Aug 7, 2026
SpyZzey
left a comment
Member
There was a problem hiding this comment.
I think this approach might have two flaws:
- It's inconsistent and not transparent to the user. The behavior can change depending content without a visual clue (might need to be checked with a designer).
- The accessibility issue still persists for places where there is a button or link inside the expandable section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The expand chevron in the expandable section
navigationvariant (used by side navigation expandable link groups) has a ~12px pointer target, failing WCAG 2.5.8 Target Size (Minimum, 24x24px).The header wrapper already shows
cursor: pointerbut had no click handler. This change makes it handle pointer clicks, deferring to interactive descendants (expand button, header link), so the effective target becomes the whole header row.Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.