Skip to content

refactor: decouple flash and alert styling from shared tokens - #4873

Closed
mxschll wants to merge 1 commit into
dev-v3-schomax-topnav-alert-fixfrom
dev-v3-schomax-notification-tokens
Closed

refactor: decouple flash and alert styling from shared tokens#4873
mxschll wants to merge 1 commit into
dev-v3-schomax-topnav-alert-fixfrom
dev-v3-schomax-notification-tokens

Conversation

@mxschll

@mxschll mxschll commented Aug 6, 2026

Copy link
Copy Markdown
Member

Flashes and alerts style parts of their content through shared tokens (colorTextStatus*, colorBackgroundStatus*, progress bar colors), restyled via their visual contexts. This couples them to unrelated consumers of the same tokens (popovers, standalone progress bars).

New component-scoped tokens, all referencing the previously used shared tokens:

  • colorTextAlertDefault, colorBackgroundAlert*, colorTextAlertIcon*
  • colorTextFlashbarIcon*
  • colorBackgroundProgressBarFlash, colorBackgroundProgressBarValueFlash (progress bars in flash messages now carry a progress-flash class)

Since the values are references, the emitted CSS keeps the var() chain and existing contexts stay in control: no visual change in any theme. This unblocks themes that style notifications without contexts (#4866).

Stacked on #4872; base for #4866.

@mxschll
mxschll requested a review from a team as a code owner August 6, 2026 09:51
@mxschll
mxschll requested review from amanabiy and removed request for a team August 6, 2026 09:51
@mxschll
mxschll marked this pull request as draft August 6, 2026 09:52
@mxschll mxschll changed the title refactor: Decouple flash and alert styling from shared tokens refactor: decouple flash and alert styling from shared tokens Aug 6, 2026
@mxschll

mxschll commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

Folded into #4866 — the stack was collapsed after dropping the visual refresh fix (#4872).

@mxschll mxschll closed this Aug 6, 2026
@mxschll
mxschll deleted the dev-v3-schomax-notification-tokens branch August 6, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant