chore: Widen peerDependencies to accept react-router-dom 7 - #72
Merged
ernst-dev merged 1 commit intoAug 7, 2026
Merged
Conversation
ernst-dev
force-pushed
the
dependabot-remediate/security-remediation-20260807
branch
from
August 7, 2026 13:43
161126c to
9d5713c
Compare
ernst-dev
added a commit
to cloudscape-design/board-components
that referenced
this pull request
Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'. Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72), npm ci needs legacy-peer-deps to resolve the optional peer without failing. This file can be removed once build-tools#72 is merged.
ernst-dev
added a commit
to cloudscape-design/chart-components
that referenced
this pull request
Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'. Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72), npm ci needs legacy-peer-deps to resolve the optional peer without failing. This file can be removed once build-tools#72 is merged.
ernst-dev
added a commit
to cloudscape-design/chat-components
that referenced
this pull request
Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'. Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72), npm ci needs legacy-peer-deps to resolve the optional peer without failing. This file can be removed once build-tools#72 is merged.
ernst-dev
added a commit
to cloudscape-design/code-view
that referenced
this pull request
Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'. Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72), npm ci needs legacy-peer-deps to resolve the optional peer without failing. This file can be removed once build-tools#72 is merged.
ernst-dev
added a commit
to cloudscape-design/component-toolkit
that referenced
this pull request
Aug 7, 2026
@cloudscape-design/build-tools declares peerOptional react-router-dom@'^5.3.0 || ^6.0.0'. Until build-tools is updated to accept ^7.0.0 (PR cloudscape-design/build-tools#72), npm ci needs legacy-peer-deps to resolve the optional peer without failing. This file can be removed once build-tools#72 is merged.
ernst-dev
force-pushed
the
dependabot-remediate/security-remediation-20260807
branch
from
August 7, 2026 13:52
8ff05a8 to
008aa49
Compare
Adds ^7.0.0 to the peerOptional react-router-dom range so consuming repos can upgrade to react-router-dom 7 without peer dep conflicts. The 3 Dependabot alerts on this repo (GHSA-wrjc-x8rr-h8h6, GHSA-337j-9hxr-rhxg, GHSA-jjmj-jmhj-qwj2) remain UNFIXABLE here: react-router-dom 7 requires react>=18, but this package must retain react@16 support. No patched version exists within the 6.x line.
ernst-dev
force-pushed
the
dependabot-remediate/security-remediation-20260807
branch
from
August 7, 2026 13:53
008aa49 to
23bd560
Compare
ernst-dev
enabled auto-merge
August 7, 2026 14:07
amanabiy
approved these changes
Aug 7, 2026
ernst-dev
deleted the
dependabot-remediate/security-remediation-20260807
branch
August 7, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
react-router-domfrom^6.30.4to^7.18.2(dev dependency) to resolve all 3 open Dependabot security alerts.NPMPM availability
Not applicable — all upgraded packages are dev-only dependencies (
dev: truein lockfile). No non-dev dependency versions increased.Alerts resolved
Remediation details
npm install react-router-dom@^7.18.2 --save-dev) with HW4 lockfile splice — no patch available within 6.x; all 3 alerts require the 6→7 major version upgrade.peerDependencies: {react: '>=18'}but this repo pins [email protected] as a devDependency. Installed with--legacy-peer-deps. Since react-router-dom is only a dev dependency used for dev pages, this mismatch is acceptable.react-router6.30.4 → 7.18.2,react-router-dom6.30.4 → 7.18.2[email protected]added (new react-router dep),[email protected]added (new react-router dep),@remix-run/[email protected]removed (no longer used in v7)Unresolved alerts
None — merging this PR is expected to CLEAR ALL 3 open Dependabot alerts for this repo.
Notes
react-router-domis a devDependency only, used for dev pages / testing. The 6→7 migration is a breaking change for application code but low-risk for this repo's dev tooling.@cloudscape-design/*entries in lockfile).package.json+package-lock.json.