Repository navigation
fix(cli): retry post-deploy calls while the new deployment token spreads - #64
Merged
Merged
Conversation
Workers Builds makes a new deployment token on every build. Right after `wrangler deploy` the edge can still answer from the previous admin Worker version, so the push check got 401 and the build failed although both Workers had deployed (cloudhal.com, 0.3.9 update). The push and the primary-domain calls after a deploy now retry on 401 for up to 90 s. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cloudhal.com's Workers Build for the 0.3.9 update failed after both Workers had deployed:
Workers Builds makes a new deployment token on every build; for a few seconds after
wrangler deploythe edge can still answer from the previous admin Worker version, which has the previous token. The health check passes (it needs no token), then the authenticated push check gets 401.whileTokenPropagates(deploy/resources.ts) retries a step for up to 90 s while it fails with(401);afterDeploywraps the push and both primary-domain calls in it. Other failures are not retried.Tests:
token-propagation.test.ts(retries then succeeds, no retry on 500, gives up after the timeout);deploy.test.tsunchanged and green.🤖 Generated with Claude Code