Repository navigation
fix(cli): snapshot --publish skips when nothing changed - #58
Merged
Merged
Conversation
…e snapshot Re-running a setup script made a new snapshot every time, padding the history. With --publish and no pending changes against the live snapshot (the store's pendingChanges, which ignores the site node's publish pointer), the command now returns the live snapshot and prints "nothing changed since <id> (live); no new snapshot". Closes #51 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51.
cloudhal snapshot --publishwith no changes against the live snapshot now makes no new snapshot and printsnothing changed since <id> (live); no new snapshot. The check is the store'spendingChanges(the same diff the publish approval shows), so the site node's own publish pointer does not count as a change.snapshotwithout--publishstill always records one (an explicit checkpoint).packages/cli/src/commands/snapshot.ts:unchangedLive;snapshot()returns the live snapshot withunchanged: true(typeSnapshotResult, still aSnapshotfor callers).cli/commands-local.ts: the message.test/e2e.test.ts: a second publish returns the same id,unchanged.Checked on a test site: two runs in a row both say nothing changed.
🤖 Generated with Claude Code