Skip to content

test(mcp-server): await the edit in the H2 approval test #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Madraka merged 2 commits into from
Oct 21, 2026
Merged

test(mcp-server): await the edit in the H2 approval test #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9dbae0
test(mcp-server): await the edit in the H2 approval test
Madraka Oct 21, 2026
6578101
test(mcp-server): type the async answer as Promise<Answer>
Madraka Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/mcp-server/test/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ async function connect(opts: {
store: SiteGraphStore;
audit: AuditLog;
elicitation: boolean;
answer?: () => Answer;
answer?: () => Answer | Promise<Answer>;
prompts?: string[];
confirmTokenFallback?: boolean;
approvals?: ApprovalStore;
Expand All @@ -45,7 +45,7 @@ async function connect(opts: {
if (opts.elicitation) {
client.setRequestHandler("elicitation/create", async (req) => {
opts.prompts?.push(req.params.message);
const action = opts.answer?.() ?? "accept";
const action = (await opts.answer?.()) ?? "accept";
return action === "accept" ? { action, content: { confirm: true } } : { action };
});
}
Expand Down Expand Up @@ -281,18 +281,16 @@ describe("MCP client ↔ Cloudhal server", () => {
store,
audit,
elicitation: true,
answer: () => {
// The edit is awaited before answering: it must land before the retry, whatever the load.
answer: async (): Promise<Answer> => {
if (!edited) {
edited = true;
void (async () => {
const page = (await store.listPages(siteId))[0];
if (page) await store.updatePage({ ...page, title: "Changed after the question" });
})();
const page = (await store.listPages(siteId))[0];
if (page) await store.updatePage({ ...page, title: "Changed after the question" });
}
return "accept";
},
});
await new Promise((r) => setTimeout(r, 0));
const r = await client.callTool({ name: "publish", arguments: { siteId } });
expect(r.isError).toBe(true);
expect((r.content[0] as { text: string }).text).toMatch(/site changed meanwhile/);
Expand Down
Loading