Repository navigation
fix(cli): deploy the admin Worker under its own name in Workers Builds - #29
Merged
Merged
Conversation
Workers Builds sets WRANGLER_CI_OVERRIDE_NAME to the connected Worker; wrangler then deployed the admin Worker under the site Worker's name, so the first Deploy to Cloudflare run served Studio at the site's address and created no admin Worker. cloudhal deploy now drops the override (and WRANGLER_CI_MATCH_TAG) and names each Worker itself. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Merged
Madraka
added a commit
that referenced
this pull request
Oct 20, 2026
…name fix(cli): deploy the admin Worker under its own name in Workers Builds
Madraka
added a commit
that referenced
this pull request
Oct 20, 2026
The Deploy to Cloudflare button deploys the admin Worker under its own name (#29). Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on the first real Deploy to Cloudflare run, from the template on 0.2.0. The site Worker's address served Studio, and no
cloudhal-blog-adminWorker existed. Both uploads went tocloudhal-blog-site, 2 s apart.Cause: Workers Builds sets
WRANGLER_CI_OVERRIDE_NAMEto the connected Worker. wrangler'sresolveWorkerNameprefers it over the config'sname, so everywrangler deploy(andwrangler secret) targeted the site Worker.Fix:
wranglerRunnerno longer passesWRANGLER_CI_OVERRIDE_NAMEorWRANGLER_CI_MATCH_TAGto wrangler.cloudhal deploynames each Worker itself, and the site keeps the connected name.Tests and docs: a new
test/wrangler-ci-env.test.ts;docs/guides/deploy-button.mdexplains how to recover a deployment made before 0.3.2.wrangler-ci-env,deploy-workers-builds,deployandcloudflare-deploytests; cli typecheck.🤖 Generated with Claude Code