Repository navigation
fix(release): wait for a new draft to show in the releases list - #210
Merged
Merged
Conversation
The first Release dry run (run 43184427067) created the draft v0.8.0-dryrun.171 and failed one second later with "expected one release v0.8.0-dryrun.171, found 0": GitHub's releases list shows a just-created draft only after a few seconds, and a draft whose tag is not pushed has no releases/tags/ URL. createDraft now waits until the list shows it (1, 2, 4, then 8 s per try). The cleanup step found and deleted the draft 1.6 s later. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The first Release dry run after #208 (run 43184427067) failed in
publish:GitHub's releases list shows a just-created draft only after a few seconds. A draft whose tag is not pushed yet has no
releases/tags/URL, so the list is the only way to find it. Thealways()cleanup step found the draft 1.6 s later and deleted it; nothing was published, and no tag or draft is left.createDraftinscripts/publish-ci.tsnow waits until the list shows the draft, retrying after 1, 2, 4, then 8 s per try (about a minute at most), beforesync-assetsruns. The same delay hits a real release, whose draft is created before the tag is published, so this applies to every run, not only dry runs. The planner and driver inrelease-publish-plan.tsare unchanged.The rest of the dry run passed:
bundlebuilt and attested, andbundle-signverified the attestation and the statement and signed with the run's throwaway key.Checklist
pnpm checkandcargo test --workspacepass locally (biome, size-check,turbo run typecheck20/20,@cloudhal/clirelease tests 39/39 incl. three newwaitForDraftcases; no Rust change)git commit -s, DCO)🤖 Generated with Claude Code