Repository navigation
ci(release): template sync by hand when the GitHub App is missing - #164
Merged
Merged
Conversation
The 0.6.3 release's Template sync job only logged a notice (no TEMPLATE_SYNC_APP_CLIENT_ID variable, no TEMPLATE_SYNC_APP_PRIVATE_KEY secret), so cloudhal-template was synced by hand with scripts/template-sync.ts (cloudhal-dev/cloudhal-template#4). What that run showed: - scripts/template-pr.ts: without a run URL the PR body still said the release workflow opened the PR and that the Template sync run had checked a copy. It now says a hand run of the script did, and who checks it. Test added. - CONTRIBUTING.md, Releasing: the by-hand recipe (the two script commands, the copy check, the branch, the PR and the status), and why Dependabot's PR on the template is no substitute: it moves @cloudhal/* only and fails to install once the starter's own pins moved, as in 0.6.3 (astro 7.4.7 for the ^7.4.0 peer range). - scripts/template-sync.ts and the workflow header point at that recipe. Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 0.6.3 release. Its Template sync job only logged a notice (the
TEMPLATE_SYNC_APP_CLIENT_IDvariable and theTEMPLATE_SYNC_APP_PRIVATE_KEYsecret are not set), so cloudhal-template was synced by hand withscripts/template-sync.tsfrom a checkout: cloudhal-dev/cloudhal-template#4. The script needed no change for the versions: the published starter already carries astro 7.4.7, @astrojs/cloudflare 14.4.4 and wrangler ^4.158.0, and the sync takes the starter's dependency maps wholesale. What the hand run did show:scripts/template-pr.ts: with no run URL, the PR body still claimed the release workflow opened the PR and that "the Template sync run" had checked a copy. The last two paragraphs now depend onrunUrl: a hand run says so and names who checks it. One test added inpackages/cli/test/template-sync.test.ts.CONTRIBUTING.md, Releasing step 5: the by-hand recipe (the two script commands, the copy check withnpm ciandWORKERS_CI=1 npx cloudhal deploy --dry-run, thecloudhal/vX.Y.Zbranch, the PR, thecloudhal/template-checkstatus), and why Dependabot's PR on the template is no substitute: it moves@cloudhal/*only and fails to install once the starter's own pins moved (0.6.3: astro 7.4.7 for the^7.4.0peer range).scripts/template-sync.tsheader and the.github/workflows/template-sync.ymlcomment point at that recipe.No changeset: scripts and docs only. Checks run locally:
biome check(no errors),pnpm --filter @cloudhal/cli typecheck,vitest run test/template-sync.test.ts(20 passed),node scripts/size-check.ts.To enable the automatic sync (CONTRIBUTING.md, Releasing): create a GitHub App on the cloudhal-dev organization with Contents, Pull requests and Commit statuses write, install it on cloudhal-template only, then set the
TEMPLATE_SYNC_APP_CLIENT_IDrepository variable and theTEMPLATE_SYNC_APP_PRIVATE_KEYsecret on cloudhal-dev/cloudhal. Actions › Template sync › Run workflow with0.6.3would then rebuildcloudhal/v0.6.3frommainand replace the hand-made branch.🤖 Generated with Claude Code