Skip to content

chore(deps): patch updates and audit fixes (#115) - #126

Merged
Madraka merged 1 commit into
mainfrom
chore/issue-115-deps-audit
Oct 25, 2026
Merged

Madraka merged 1 commit into
mainfrom
chore/issue-115-deps-audit

Conversation

@Madraka

@Madraka Madraka commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

What

Fixes #115.

Patch updates

Every target is same-minor and older than pnpm 12's 24 h minimum release age.

Package From To Note
better-auth, @better-auth/core, api-key, kysely-adapter 1.7.7 1.7.12
better-call 1.4.0 1.4.4 exact pin of better-auth 1.7.12
@better-auth/utils 0.4.2 0.5.0 better-auth 1.7.12 pins it exactly, so better-auth-pins.test.ts requires it; not a same-minor move
react, react-dom 19.3.0 19.3.1
@tanstack/react-router 1.170.41 1.170.46 newer than the issue's .45
@tanstack/react-query 5.104.4 5.104.5
vite 8.3.3 8.3.5 rolldown 1.2.15, postcss 8.5.31
vitest 5.0.3 5.0.5
turbo 2.11.7 2.11.10
marked 18.1.0 18.1.1
temporal-polyfill 1.0.5 1.0.6
happy-dom 21.0.3 21.0.4 also fixes high GHSA-834v-8h66-3h79, published after the issue
@codemirror/view 6.43.14 6.43.15
zod 4.6.5 4.6.7 high GHSA-mrhx-c7xc-m3w5, production path; @cloudhal/cloudflare asks for ^4.6.7

Audit decision

The decision is recorded in a new ADR-0012 addendum (2026-10-25).

  • sharp: overridden. overrides: "sharp@<0.35.5": 0.35.5 in pnpm-workspace.yaml.
    • Miniflare pins sharp exactly: 4.20260730.0 (ADR-0012's pin) to 0.35.2, and the 5.x alpha inside wrangler 4.148 and @cloudflare/vite-plugin 1.63 to 0.35.4.
    • The override clears GHSA-wq5f-xc86-pv6w and GHSA-rgj7-g3m4-5g8c.
    • Miniflare loads sharp only for the Images binding and cf.image mocks, and Cloudhal uses neither.
    • Overrides are not published, and the addendum says what that means for consumers.
  • wrangler: stays at 4.148. 4.152 is a minor move that changes the Miniflare under createTestHarness and the deploy source-map default; it gets its own PR.
  • undici under Miniflare: accepted for local use. The fix is a minor move inside dispatchFetch.
  • postcss-selector-parser 6.1.5: unchanged. It is on the docs build path only.

Also in this PR

  • packages/api/test/auth.test.ts: a regression test for Better Auth 1.7.8's change-password with revokeOtherSessions (now run in a transaction on SQLite). It runs on SQLite and D1.
  • apps/studio/vitest.config.ts: fsModuleCache: false. Vitest ≥ 5.0.4 caches transformed modules on disk, and the cache key misses the catalogs plugin, so a compiler change could test stale catalogs.
  • turbo.json: agentGuidance: true. turbo 2.11.10 made AGENTS.md's managed block opt-in, so this keeps today's behaviour. turbo also rewrote the block's own wording.
  • AGENTS.md versions line.
  • Changeset: patch for api, cloudflare, core-ts, schedules, astro-renderer and cli. It notes that marked 18.1.1 splits a few unusual markdown inputs differently.

Verification (local, one command at a time)

  • pnpm install --frozen-lockfile is clean.
  • pnpm dedupe --check finds nothing. Each of zod, better-auth's utils, react and vite resolves to a single version.
  • The only unplanned lockfile change is @oxc-project/types 0.152 → 0.155, an exact pin of rolldown 1.2.15.
  • Fresh serial turbo run typecheck/test --concurrency=1 --force:
    • typecheck 20/20;
    • test 19/19, 4,937 tests passed, 1 skipped (analytics);
    • core-ts 988, studio 1275, api 423, cli 179, cloudflare 54;
    • no EADDRNOTAVAIL.
  • biome, size:check, Studio build (bundle budget OK) and scripts/smoke-pack.ts all pass.
  • pnpm audit --prod afterwards: 7 advisories left, all accepted above (undici under Miniflare and unifont, postcss-selector-parser on the docs path).

Review process:

  • Three reviewers looked at the lockfile, the security decision and docs/release.
  • A separate agent tried to refute each finding.
  • One finding held up: a wrong sentence in the ADR addendum about what undici is used for. It is fixed here.

Checklist

  • pnpm check passes locally (serial, see above). cargo test --workspace was not run: no Rust or contract changes.
  • Contract change? None.
  • User-visible change in a published package? .changeset/deps-issue-115.md
  • Commits are signed off (git commit -s, DCO)
  • Docs / AGENTS.md updated: AGENTS.md versions line and an ADR-0012 addendum

🤖 Generated with Claude Code

Same-minor patches, all past pnpm 12's 24 h minimum release age:
better-auth and @better-auth/* 1.7.7 -> 1.7.12 with better-call 1.4.4 and
@better-auth/utils 0.5.0 (better-auth 1.7.12 pins it exactly; the pins test
holds), react/react-dom 19.3.1, TanStack Router 1.170.46 and Query 5.104.5,
vite 8.3.5, vitest 5.0.5, turbo 2.11.10, marked 18.1.1, temporal-polyfill
1.0.6, happy-dom 21.0.4 (GHSA-834v-8h66-3h79), @codemirror/view 6.43.15 and
zod 4.6.7 (GHSA-mrhx-c7xc-m3w5).

Audit: sharp@<0.35.5 is overridden to 0.35.5 for Miniflare's exact pins
(GHSA-wq5f-xc86-pv6w, GHSA-rgj7-g3m4-5g8c); wrangler stays 4.148 and the
undici advisories under Miniflare are accepted for local use. Recorded in an
ADR-0012 addendum. postcss-selector-parser stays on the docs build path.

Also: a Better Auth 1.7.8 regression test (change-password with
revokeOtherSessions), Studio's Vitest disk module cache off (vitest >= 5.0.4;
its key misses the catalogs plugin), turbo.json agentGuidance kept on after
turbo 2.11.10 made it opt-in, and AGENTS.md's version list.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Madraka <[email protected]>
@Madraka
Madraka merged commit f8a85ed into main Oct 25, 2026
6 checks passed
@Madraka
Madraka deleted the chore/issue-115-deps-audit branch October 25, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deps: patch updates and two audit findings (sharp via miniflare, postcss via starlight)

1 participant