Repository navigation
Run CodeQL in the local audit - #62
Merged
Merged
Conversation
0001-dependency-updates was published in the v1.24.5 notes. changelog-sweep left the removal staged so it rides this PR rather than a direct push to master.
Picks up make codeql: the go-code-scanning suite code scanning uses, failing on any finding, with the database built without the build tracer so it runs on Apple Silicon without Rosetta. The vendored copy is byte-identical to GNUMakefile-Snippets f386def.
make audit now ends with codeql, so a contributor's pre-PR audit covers what code scanning will report. CI's audit job runs make security modrot instead: codeql.yml already analyzes every PR and uploads to code scanning, and installing the CLI there would only repeat it.
Tells future maintainers that make audit now runs CodeQL, what it needs locally, and why CI's audit job skips it.
norman-abramovitz
force-pushed
the
add-codeql-target
branch
from
October 28, 2026 20:15
3aea933 to
d6c9714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CodeQL to
make auditfor local runs.mk/security.mkfor the newmake codeqltarget, fromAdd a CodeQL scan target to security.mk norman-abramovitz/GNUMakefile-Snippets#12 (merged). The vendored copy is
byte-identical to upstream main at f386def.
audit: security modrot codeql, so a contributor's pre-PR auditcovers what code scanning will report.
make security modrotinstead:codeql.ymlalready analyzes every PR and uploads to code scanning.
changelog.d/0001-dependency-updates.md, published in thev1.24.5 notes.
Locally:
make auditpasses (CodeQL: no findings, ~17s total),make actionlintandmake changelog-checkpass.