Skip to content

ecc/goldilocks: reject trailing data when decoding a point #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxbjavid wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ecc/goldilocks: reject trailing data when decoding a point #707

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
317278c
ecc/goldilocks: reject trailing data when decoding a point
dxbjavid Oct 5, 2026
17498f7
Use human language
bwesterb Oct 5, 2026
68429c0
tabs
bwesterb Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ecc/goldilocks/point.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ func isLessThan(x, y []byte) bool {
}

// FromBytes returns a point from the input buffer.
//
// Note, previous versions of Circl accepted trailing data.
func FromBytes(in []byte) (*Point, error) {
if len(in) < fp.Size+1 {
if len(in) != fp.Size+1 {
return nil, errors.New("wrong input length")
}
err := errors.New("invalid decoding")
Expand Down
Loading