feat(argocd): ajoute le registre harbor du projet aux sources ArgoCD - #2705
Open
KepoParis wants to merge 1 commit into
Open
feat(argocd): ajoute le registre harbor du projet aux sources ArgoCD#2705KepoParis wants to merge 1 commit into
KepoParis wants to merge 1 commit into
Conversation
|
shikanime
requested changes
Sep 9, 2026
shikanime
left a comment
Member
There was a problem hiding this comment.
plutot avoir une config generique sharedSourceRepositories ou un truc comme ca ? que d'avoir une dependance transverse vers Harbor
KepoParis
force-pushed
the
feat/argocd-registry-oci-source
branch
from
September 10, 2026 09:02
c6b1db7 to
74dac96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0 New Issues
0 Fixed Issues
0 Accepted Issues
Issues liées
Issues numéro: #1608 (reste ouverte, des changements front et probablement back sont encore nécessaires)
Quel est le comportement actuel ?
sourceRepositoriesne contient que l'URL GitLab du projet et les dépôtssupplémentaires du plugin. Les charts poussés dans le registre Harbor du projet
ne sont pas déclarés comme source autorisée.
Quel est le nouveau comportement ?
sourceRepositoriescontient aussioci://<host harbor>/<slug projet>/**.L'URL est reconstruite depuis
new URL(...).host, ce qui supprime le protocoleet tout slash final, donc pas de double slash.
L'entrée est omise si le registre est désactivé. ArgoCD lit
USE_HARBORetHARBOR_URLdans sa propre config, avec la même règle que leConditionalModulequi enregistre
RegistryModule(désactivé uniquement sur unfalseexplicite).Passer par
harborConfigFactoryaurait cassé le démarrage d'ArgoCD sans Harbor,ses identifiants étant obligatoires.
Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Tests ajoutés:
USE_HARBOR=falseavecHARBOR_URLdéfini,USE_HARBORabsent,HARBOR_URLabsent, et un cas service sans registre.