refactor(server-nestjs): split Vault makeVaultHandlers into subfunctions - #2673
Closed
shikanime wants to merge 1 commit into
Closed
refactor(server-nestjs): split Vault makeVaultHandlers into subfunctions#2673shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
Split makeVaultHandlers into per-resource subfunctions for readability: - makeVaultKvHandlers (kv read/write/metadata/list) - makeVaultSysHandlers (policies, mounts, approle, auth methods) - makeVaultIdentityHandlers (identity group CRUD) - makeVaultTokenHandlers (token creation) Preserve existing factory functions: makeProjectWithDetails, makeZoneWithDetails, makeVaultSecret, makeVaultSecretMetadata Refs #2655 Co-authored-by: Automata <[email protected]> Signed-off-by: Shikanime Deva <[email protected]> Signed-off-by: William Phetsinorath <[email protected]> Change-Id: If9d9d123a0a479f6ae769647190c1bca6a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split Vault makeVaultHandlers into per-resource subfunctions: kv, sys, identity, token.
Stacking on: PR #2672