fix(server-nestjs): make SonarQube user creation idempotent on create race - #2639
Merged
Conversation
… race Refs: #2633 Signed-off-by: William Phetsinorath <[email protected]> Change-Id: Ib4be9a86e1f36e06b70daf1975411f0f6a6a6964
shikanime
marked this pull request as ready for review
September 1, 2026 12:13
shikanime
enabled auto-merge
September 1, 2026 12:13
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
StephaneTrebel
approved these changes
Sep 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 7, 2026
Contributor
|
🤖 Hey ! A preview of the application is available at : https://console-pr-2639.dso.cpin-hp.numerique-interieur.fr Please be patient, deployment may take a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
#2633 (fermer délibérément après la fusion)
Quel est le comportement actuel ?
Lors de la synchronisation SonarQube d'un projet,
ensureUserappelleclient.createUser(POSTusers/create). Sous synchronisations concurrentes, la seconde création reçoit une erreur 400 « already exists » (ou 409) et interrompt toute la synchronisation du projet.Quel est le nouveau comportement ?
createUserapplique le motifensurepartagé par la campagne d'idempotence (#2624, #2627, #2605) : à la création, une collision (409, ou 4xx dont le message évoque une ressource déjà présente) déclenche une relecture de l'utilisateur existant viausers/search, qui est retournée à la place. Toute autre erreur est relancée telle quelle.isSonarqubeAlreadyExistsetensuredanssonarqube.utils.ts, calqués sur les utilitaires gitlab/nexus.isSonarqubeAlreadyExists.Cette PR introduit-elle un breaking change ?
Non.
Autres informations
Suit #2605 #2623 #2624 #2626 #2627 #2632.