Repository navigation
feat: find fgumi and fgbio variant reviews with bedspec.ext.captainslog - #90
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
bedspec.ext.captainslog, whoseas_intervalnow also reads the variant reviews of captainslog's newcaptainslog.fgumiandcaptainslog.fgbio(clintval/captainslog#5, released in 0.2.0) as 0-based, half-open spans, to register withregister_locatable.fgumi's
reviewand fgbio'sReviewConsensusVariantswrite one row for each consensus read carrying a variant, and each row covers the base of its variant.fgumi.ConsensusVariantReviewInfo,fgbio.ConsensusVariantReviewInfochrom,posPOSA review row is a
Bed3, like a CpG.The extension names a span for the feature it covers, a target or a SNP, and never for the sample or read group a row also holds.
A review row's only name is its
consensus_read, which is one of many reads at the same variant and spans more than the variant's base, so it does not name the feature at the span.No other fgumi or fgbio record is located.
ErrorRateByReadPositionMetric.positionis a cycle within a read, not a position on the reference, so the record raisesTypeErrorlike any other; the rest, and fgbio's hand-written histograms, hold no coordinates.Dependencies
captainslogextra rises fromcaptainslog-ngs >=0.1.0to>=0.2.0, the first release withcaptainslog.fgumiandcaptainslog.fgbio. The lock moves from 0.1.0 to 0.2.0 and changes nothing else.Testing
uv run poe check-allpasses on the locked captainslog 0.2.0: 729 tests, none skipped, and mypy and basedpyright clean.review.txtfixture, which fgumi and fgbio write byte for byte the same, both tools' rows giveBed3("chr1", start=500, end=501), and that base of the simulated reference is the row'sref, anAbetween aCand aG.TreeDetectorof registered review rows finds the row at its base and not at the bases on either side.Release
This PR bumps bedspec to 4.4.0 in
pyproject.tomlanduv.lock, a minor release for the records it now locates.After the squash merge, tagging the merge commit
4.4.0publishes it.Summary by CodeRabbit