Repository navigation
fix(deep): reject sparse sort input before mutation - #255
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
deepSortintroduced in #254 can duplicate an existing record when its input contains a hole:mappreserves the hole, sorting moves the populated entry, and writing the result back leaves the original populated slot in place. Validate every position withArray.fromso a missing record rejects before sorting or mutation.Original request
Provide reusable, documented deep helpers with a unit-test safety net. This follows up on a sparse-input case found while verifying the newly merged sorter.
What changed
Reasoning
The existing validation-before-mutation contract should apply to sparse arrays as well. The fix preserves ordinary stable sorting and the public interface.
Type of Change
Blog post
Skipped: correctness fix in a non-visual data-processing helper.
Screenshots / preview evidence
Not applicable: pure data helper. A before/after reproduction demonstrates duplication on the original implementation and rejection without mutation after the fix.
Validation
npm run lint,npm run build,npm run test: pass.npm run test:coverage: all published-package floors pass; the sorter retains 100% lines/statements/functions/branches.Checklist