Repository navigation
feat(server): add cooperative request cancellation and deadlines - #253
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Request handlers need a reusable way to cancel cooperative work when the client disconnects, a deadline expires, or a caller cancels.
withRequestSignal(context, work, { timeoutMs, signal? })provides that lifecycle and releases its timer/listeners whenever work settles. Deadline policy remains with the application, and normal response completion does not produce a false disconnect.Original request
Move reusable request-owned cancellation/deadline handling into Framework, with documentation and a unit-test safety net.
What changed
Reasoning
A scoped helper makes the lifetime explicit without changing handler types, HTTP statuses, or application timeout defaults. It does not race arbitrary work that would continue performing effects after rejection.
Type of Change
Blog post
Skipped: internal server infrastructure API; the package README and JSDoc document the feature.
Screenshots / preview evidence
Not applicable: this adds a non-visual server helper with no demo route or UI change. Real HTTP lifecycle objects are exercised in unit tests. Consumer preview verification belongs to its integration PR.
Validation
npm run lint,npm run build,npm run test: pass.npm run test:coverage: all published-package floors pass; the new helper has 100% lines/statements/functions/branches.Checklist