Skip to content

Upgrade ESLint to v10#246

Open
martnpaneq wants to merge 7 commits into
masterfrom
ck/4327-eslint-v10
Open

Upgrade ESLint to v10#246
martnpaneq wants to merge 7 commits into
masterfrom
ck/4327-eslint-v10

Conversation

@martnpaneq

@martnpaneq martnpaneq commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Part of https://github.com/ckeditor/ckeditor5-internal/issues/4327.

Upgrades ESLint from v9 to v10 and aligns the shared CKEditor 5 linter packages:

  • eslint^10.0.0
  • eslint-config-ckeditor5^18.0.0
  • eslint-plugin-ckeditor5-rules^18.0.0

@martnpaneq
martnpaneq marked this pull request as ready for review July 21, 2026 10:57

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f56d94. Configure here.

Comment thread package.json Outdated
@pomek

pomek commented Jul 22, 2026

Copy link
Copy Markdown
Member

eslint-plugin-import – this package does not support ESLint 10 (via peerDependencies)

image

Question: Do we need it?

… replaced its import/extensions rule with the built-in ckeditor5-rules/require-file-extensions-in-imports.
@martnpaneq

Copy link
Copy Markdown
Contributor Author

Turns out that eslint-plugin-import is not needed. We can replace a single rule that we use from it: import/extensions by rule ckeditor5-rules/require-file-extensions-in-imports.

And dropping a dependency means less maintenance in the future.

…s to ^18.1.0 (unify the linter-config version).
… to ^19.0.0 and @ckeditor/ckeditor5-dev-* to ^58.0.0 (latest).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants