Skip to content

fix: require complete OpenAI opt-out state - #11

Merged
ygpark80 merged 1 commit into
mainfrom
fix/registered-oauth-opt-out-completeness
Sep 10, 2026
Merged

ygpark80 merged 1 commit into
mainfrom
fix/registered-oauth-opt-out-completeness

Conversation

@ygpark80

@ygpark80 ygpark80 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

User description

Problem

off could treat an OpenAI settings response with missing feature fields as fully opted out because it only checked for enabled values.

Change

Require every supported OpenAI training feature to be present and explicitly false before skipping an already-clean registered OAuth account. Add a regression test for missing fields.

Validation

  • go test ./...
  • go test -race ./...
  • go vet ./...
  • Linux amd64 and macOS arm64 builds

CodeAnt-AI Description

Require complete OpenAI opt-out confirmation before skipping accounts

What Changed

  • Registered OpenAI accounts are skipped only when every supported training feature is explicitly confirmed as off
  • Missing or unknown training settings now trigger the opt-out action instead of being treated as already disabled
  • Added coverage for incomplete training settings

Impact

✅ Fewer accounts left with uncertain OpenAI training settings
✅ Complete opt-out verification
✅ Regression protection for missing feature data

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai

codeant-ai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR c71a6d7 Sep 10, 2026 · 07:43 07:44

@codeant-ai

codeant-ai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: bd8424ba-2946-4972-9faa-e1451f6f4631


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Sep 10, 2026
@ygpark80
ygpark80 merged commit 3b1b07e into main Sep 10, 2026
2 checks passed
@ygpark80
ygpark80 deleted the fix/registered-oauth-opt-out-completeness branch September 10, 2026 07:44
Comment thread main.go
Comment on lines +962 to 964
if checked.OK && allTrainingOff(checked.Training) {
continue
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: A settings read can become stale before the separate update request, so a concurrent change may leave training enabled while this command skips the corrective update. [race condition]

Assessment: 🟠 Major · 🔁 Occurrence: Rarely

Use CodeAnt Skill Fix in Cursor Fix in VSCode Claude

Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** main.go
**Line:** 962:964
**Comment:**
	*Race Condition: A settings read can become stale before the separate update request, so a concurrent change may leave training enabled while this command skips the corrective update.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant