Repository navigation
refactor(ui): migrate workbench to gpui-kit - #43
Merged
Merged
Conversation
Adopt the Chitin-patched gpui-kit and align all workspace crates with the gpui-wgpu backend. Replace the custom panel, docking, primitive, toast, and command-terminal UI implementations with GPUI Kit components, while adding a desktop adapter that projects document state into the Kit dock model. Update desktop examples, workspace wiring, assets, tests, and lockfile for the new UI architecture.
Keep the selected document panel bound to representation controls so deferred surface and style confirmations still update the correct panel after the options menu closes. Add regression coverage for backend selection, refine terminal profile selector spacing, and align dock tab styling with the segmented theme. Update the pinned gpui-wgpu and gpui-kit revisions and refresh Cargo.lock.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Important Review skippedToo many files! This PR contains 134 files, which is 34 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (134)
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Run scheduled release builds once per week instead of daily, and publish the latest prerelease under the rolling `weekly` tag. Preserve manual dispatch and keep push and pull-request events limited to build validation.
Member
Author
|
@codex review please |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8de891b87f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .text_color(rgb(0xd7e0f2)) | ||
| .child(self.scene.interaction_hint()), | ||
| .text_color(theme.popover_foreground) | ||
| .child(format!("{:.0} {}", self.display_fps, DEFAULT_FPS_POSTFIX)), |
There was a problem hiding this comment.
When any WGPU document is displayed, this overlay now renders only the FPS counter and never calls WgpuPanelScene::interaction_hint(). As a result, the rotate/pan/zoom instructions and scene-specific status text—such as the active molecular representation—have disappeared, even though the trait still promises that the hint is displayed and every scene continues to implement it. Add the scene hint back to the viewport overlay.
Useful? React with 👍 / 👎.
AshGreyG
added
ui/ux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR merges
ui/migrate-gpui-kitintomain.The branch migrates the desktop/workbench UI toward gpui-kit and substantially reorganizes the UI architecture, including:
chitin-uiprimitives/composites;chitin-uiinto assets, views, widgets, workbench, and theme-oriented modules;The branch is currently 3 commits ahead of
mainand 0 commits behind.Review notes
This is primarily an architectural UI migration rather than a small visual change. Review is best done by subsystem:
chitin-uiprimitives and composites;