Raise ConfigException on an out-of-range period value - #355
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
A millisecond period is built with datetime.timedelta, whose C-level day count overflows for an absurdly large value like '99999999999999999999999 ms'. Because period parsing is wired into value_expr, ConfigFactory.parse_string leaked a raw OverflowError at parse time. Catch it in convert_period and raise ConfigException instead.
Author
|
Hi! Gentle nudge on this one whenever you have some bandwidth. It's a small, self-contained fix ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a config whose value is an absurdly large millisecond period crashes with a raw
OverflowError:convert_perioddoesint(tokens.value)on an unbounded digit run, and a millisecond period is built withdatetime.timedelta, whose C-level day count overflows. Sinceget_period_expr()is part ofvalue_exprin the parser, this fires at parse time, so any HOCON string containing such a value takes the whole parse down instead of reporting a config error.The fix catches the overflow in
convert_periodand raisesConfigException. Normal periods are unaffected. Added a test intests/test_periods.py.